Thanks! I tried it in a project that renders quite a lot of docstrings, and I don't see any flagrant perf hit.

Thanks! I tried it in a project that renders quite a lot of docstrings, and I don't see any flagrant perf hit.

Something might be missing though: the signatures aren't actually formatted 😅 Does it work on your side?

Once I add and use the _find_ruff util, I then get this process error:

CalledProcessError(2, ['/media/data/dev/griffe/.venv/bin/ruff', 'format', '--config "line-length=60"', '--stdin-filename', 'file.py', '-'])

Its stderr is:

'error: unexpected argument '--config "line-length' found\n\n tip: a similar argument exists: '--config'\n\nUsage: ruff format --config <CONFIG_OPTION> [FILES]...\n\nFor more information, try '--help'.\n'

I guess we simply have to split that.

OK working with the suggestion above. Let me re-check the perfs. UPDATE: same, no perf hit.

Before merging the PR (if that goes through), the documentation needs to be updated (and some of the docstrings) to reflect that now it can also use ruff when black is not found.

Thanks! Looking great 🙂 I just noticed a "bug" within the code that handles cross-references in signatures: the code currently replaces **kwargs with a unique id. The issue is that Ruff then sees something like _FRmWcKw, and will complain that it doesn't have a default value while following other parameters with default values. Black doesn't seem to care about this.

def xxxxxxxxxxxxx(_N8CL: _8E, _CaOSB3U7V0pPKKf: _r9 | None = None, _qIcd: _cE3[_uQ] | None = None, _iaxfH: _pI = 'en', _kCT1PbcXbF3Nhl5kcSLp: _cIW | None = None, _FrMwcKw: _LW): pass

error: Failed to parse file.py:1:163: Parameter without a default cannot follow a parameter with a default

We should fix this before merging 🤔 I'll do this in another commit/PR. We'll probably have to modify the param_crossref Jinja macro in _base/expression.html.jinja to leave star characters outside of cross-references. Or maybe the unique ids could simply keep stars.

Done, merging!

Thanks again @DarkaMaul 🚀

Happy this is moving along - was just thinking about this